[PATCH] D64079: Scalable Vector IR Type (Try 3)

Graham Hunter via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 07:11:40 PDT 2019


huntergr created this revision.
huntergr added reviewers: thakis, hans, rengolin, sdesmalen.
Herald added subscribers: dexonsmith, steven_wu, mehdi_amini, mgorny.

Reintroduces the scalable vector IR type from D32530 <https://reviews.llvm.org/D32530>, after it was reverted
a couple of times due to increasing chromium LTO build times. This latest
incarnation removes the walk over aggregate types from the verifier entirely,
in favor of rejecting scalable vectors in the isValidElementType methods in
ArrayType and StructType. This removes the 70% degradation observed with
the second repro tarball from PR42210.


https://reviews.llvm.org/D64079

Files:
  docs/LangRef.rst
  include/llvm/ADT/DenseMapInfo.h
  include/llvm/IR/DerivedTypes.h
  include/llvm/IR/Type.h
  include/llvm/Support/ScalableSize.h
  lib/AsmParser/LLLexer.cpp
  lib/AsmParser/LLParser.cpp
  lib/AsmParser/LLToken.h
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/LLVMContextImpl.h
  lib/IR/Type.cpp
  lib/IR/Verifier.cpp
  test/Bitcode/compatibility.ll
  test/Other/scalable-vector-array.ll
  test/Other/scalable-vector-struct.ll
  test/Verifier/scalable-global-vars.ll
  unittests/IR/CMakeLists.txt
  unittests/IR/VectorTypesTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64079.207556.patch
Type: text/x-patch
Size: 31716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190702/6d0ab825/attachment.bin>


More information about the llvm-commits mailing list