[PATCH] D64065: Skip test earlier if metric is not found in compare.py

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 05:48:27 PDT 2019


serge-sans-paille added inline comments.


================
Comment at: utils/compare.py:37
             sys.stderr.write("Error: Multiple tests with name '%s'\n" % name)
             sys.exit(1)
         names.add(name)
----------------
I don't know if it's relevant, but a missing metrics *and* empty or duplicate name would no longer raise an Exception; it's probably better to `continue` right after the sanity checks?


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64065/new/

https://reviews.llvm.org/D64065





More information about the llvm-commits mailing list