[PATCH] D58042: [LiveDebugValues] Emit parameter's entry value

[David Stenberg via Phabricator via llvm-commits]

dstenb added a comment.

In D58042#1566136 <https://reviews.llvm.org/D58042#1566136>, @djtodoro wrote:

> > Can you change this comment from describing what the code does (which is fairly obvious), to why it does it?
>
> @aprantl Sure. Thanks for the comment!
>
> > I'm sorry for the late comment, but in the future I guess this could be extended so that entry_values are emitted for locals that are expressed in terms of parameters, as GCC does?
>
> @dstenb Thanks for your attention and comments. Sure, that is the plan. This is initial set of patches that covers just non-modified function parameters. Even the initial patch within the GCC was handling just this situation. The ways for improving this (using benefits of the debug entry values) are extending the support for modified parameters (if its modification could be described as an expression over its entry value), supporting local variables, etc.
>
> > As far as I can tell, we don't tag non-parameter variables as NotModified, but can Clang later on be extended to mark them as such?
>
> Yes, it can be extended.


Okay, thanks for the clarification! Would it perhaps make sense to add a small sentence about that in those TODOs?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58042/new/

https://reviews.llvm.org/D58042