[PATCH] D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 03:15:49 PDT 2019


asb added a comment.

Hi Ed, I think it does make sense to merge D63416 <https://reviews.llvm.org/D63416> into this one. Sometimes it makes sense to separate generic changes from the target-dependent code that uses them, but given that:

- This addition is motivated by the needs of RISC-V
- D63416 <https://reviews.llvm.org/D63416> is the only reasonable way to test the change
- D63416 <https://reviews.llvm.org/D63416> is a tiny patch anyway

I think it makes sense to combine in this case, so we can review+commit in an atomic unit.

Is this something that should be specified in the RISC-V psabi doc do you think? If so, might you prepare a pull request for it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63415/new/

https://reviews.llvm.org/D63415





More information about the llvm-commits mailing list