[PATCH] D60616: Make parseBitcodeFile use a named StructType, if it exists and matches.

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 02:34:51 PDT 2019


t.p.northover added a comment.

Sorry for the double reply, Phab ate my comment.



================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:1604-1605
   SmallString<64> TypeName;
+  std::vector<std::pair<unsigned, std::shared_ptr<SmallVector<uint64_t, 64>>>>
+      TypeRecords;
 
----------------
This looks like it owns the `SmallVector` so it would be a lot simpler to make it a simple value type and `std::move` when emplacing into the `std::vector`. Reduce the size of the diff substantially too, I think.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60616/new/

https://reviews.llvm.org/D60616





More information about the llvm-commits mailing list