[PATCH] D64036: [Bitcode] Update CHECK-DAG usage in tests

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 16:42:27 PDT 2019


jdenny added inline comments.


================
Comment at: llvm/test/Bitcode/upgrade-pointer-address-space.ll:3
 
-; CHECK-DAG: !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}})
-; CHECK-DAG: !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}})
-; CHECK-DAG: !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}})
+; CHECK: !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}})
----------------
Ugh, sorry, there are two occurrences of the matching text, so we can have two `CHECK` directives.  `CHECK-DAG` does not appear useful.  Will fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64036/new/

https://reviews.llvm.org/D64036





More information about the llvm-commits mailing list