[PATCH] D58042: [LiveDebugValues] Emit parameter's entry value

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 10:10:41 PDT 2019


aprantl added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1267
+        // In addition, do not allow a single location be described as an
+        // entry value.
+        if (Instr->getDebugExpression()->isFragment() ||
----------------
Can you change this comment from describing what the code does (which is fairly obvious), to why it does it?

thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58042/new/

https://reviews.llvm.org/D58042





More information about the llvm-commits mailing list