[PATCH] D63935: [llvm-ar][test] Increase llvm-ar test coverage

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked 2 inline comments as done.
gbreynoo added a comment.

After MaskRay's suggestion I have removed all use of `rm -f %t-*`



================
Comment at: test/tools/llvm-ar/create.test:1
+# Test the creation warning and supression of that warning.
+
----------------
MaskRay wrote:
> Since you've used `## ` below..
> 
> `#` -> `##`
The times I've used `##` below has been to make comments stand out more in files that require the use of `#` on each line. Would it be preferred to standardise the use of `##` and `#` on all files regardless of their use as input YAML files?


================
Comment at: test/tools/llvm-ar/extract.test:7
+RUN: llvm-ar x %t/empty.a 2>&1 \
+RUN:   | FileCheck --allow-empty %s --implicit-check-not {{.}}
+
----------------
MaskRay wrote:
> `--implicit-check-not {{.}}` does not check a regular expression.
> 
> Use `| count 0` instead
I did some experimentation with implicit-check-not and a regular expression and it seemed to work fine, do you have a test case that illustrates the issue?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63935/new/

https://reviews.llvm.org/D63935