[llvm] r364745 - [X86] CombineShuffleWithExtract - updated description comments. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 04:33:46 PDT 2019


Author: rksimon
Date: Mon Jul  1 04:33:45 2019
New Revision: 364745

URL: http://llvm.org/viewvc/llvm-project?rev=364745&view=rev
Log:
[X86] CombineShuffleWithExtract - updated description comments. NFCI.

CombineShuffleWithExtract no longer requires that both shuffle ops are extract_subvectors, from the same type or from the same size.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=364745&r1=364744&r2=364745&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Mon Jul  1 04:33:45 2019
@@ -32180,8 +32180,8 @@ static SDValue combineX86ShuffleChain(Ar
       return DAG.getBitcast(RootVT, Res);
     }
 
-    // If that failed and both inputs are extracted from the same source type
-    // then try to combine as an unary shuffle with the larger type.
+    // If that failed and either input is extracted then try to combine as a
+    // shuffle with the larger type.
     SDValue NewRoot;
     SmallVector<int, 64> NewMask;
     SmallVector<SDValue, 2> NewInputs;
@@ -32360,8 +32360,8 @@ static SDValue combineX86ShuffleChain(Ar
     return DAG.getBitcast(RootVT, Res);
   }
 
-  // If that failed and both inputs are extracted from the same source type
-  // then try to combine as an unary shuffle with the larger type.
+  // If that failed and either input is extracted then try to combine as a
+  // shuffle with the larger type.
   SDValue NewRoot;
   SmallVector<int, 64> NewMask;
   SmallVector<SDValue, 2> NewInputs;




More information about the llvm-commits mailing list