[PATCH] D63707: [AArch64] Define ETE and TRBE system registers

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 03:25:09 PDT 2019


chill updated this revision to Diff 207256.
chill added a comment.

> This needs a subtarget feature so that it isn't enabled for targets which don't have the extension.

Both extensions are on purpose enabled unconditionally:

- ETE shares most of the system registers with ETM and these were historically unconditionally enabled in LLVM. It would be inconsistent to add  a command line option, which enables just the few extra ETE registers, or it would break existing builds if we were to explicitly enable ETM registers.
- ETE requires TRBE, after unconditionally enabling ETE, it only makes sense to do the same for TRBE


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63707/new/

https://reviews.llvm.org/D63707

Files:
  llvm/lib/Target/AArch64/AArch64SystemOperands.td
  llvm/test/MC/AArch64/ete-sysregs.s
  llvm/test/MC/AArch64/trbe-sysreg-diag.s
  llvm/test/MC/AArch64/trbe-sysreg.s
  llvm/test/MC/Disassembler/AArch64/ete.txt
  llvm/test/MC/Disassembler/AArch64/trbe.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63707.207256.patch
Type: text/x-patch
Size: 6969 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190701/198425c3/attachment.bin>


More information about the llvm-commits mailing list