[PATCH] D63879: [yaml2obj] - Allow overriding sh_offset field from the YAML.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 02:39:47 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with the comment fix.



================
Comment at: lib/ObjectYAML/ELFYAML.cpp:916
+  // obj2yaml does not dump this field. It is expected to be empty when we
+  // producing YAML, because yam2obj sets an appropriate value for sh_offset
+  // automatically when it is not explicitly defined.
----------------
"when we are producing",
yam2obj -> yaml2obj


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63879/new/

https://reviews.llvm.org/D63879





More information about the llvm-commits mailing list