[PATCH] D63935: [llvm-ar][test] Increase llvm-ar test coverage
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 29 06:43:04 PDT 2019
MaskRay added inline comments.
================
Comment at: test/tools/llvm-ar/create.test:1
+# Test the creation warning and supression of that warning.
+
----------------
Since you've used `## ` below..
`#` -> `##`
================
Comment at: test/tools/llvm-ar/dash-before-letter.test:1
+# Test the use of dash before key letters.
+
----------------
`# -> ##`
================
Comment at: test/tools/llvm-ar/extract.test:1
+# Test extract operation.
+RUN: rm -rf %t && mkdir -p %t/extracted/
----------------
`# -> ##`
================
Comment at: test/tools/llvm-ar/extract.test:7
+RUN: llvm-ar x %t/empty.a 2>&1 \
+RUN: | FileCheck --allow-empty %s --implicit-check-not {{.}}
+
----------------
`--implicit-check-not {{.}}` does not check a regular expression.
Use `| count 0` instead
================
Comment at: test/tools/llvm-ar/insert-after.test:1
+# Test inserting files after a file.
+
----------------
`# -> ##`
================
Comment at: test/tools/llvm-ar/insert-after.test:3
+
+RUN: rm -f %t-*
+RUN: touch %t1.txt
----------------
Maybe split this into `rm %t-back.a`/etc below.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63935/new/
https://reviews.llvm.org/D63935
More information about the llvm-commits
mailing list