[PATCH] D63779: [llvm-objdump] Warn if no user specified sections (-j) are found.

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked 2 inline comments as done.
ychen added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:349
     return false;
-  return is_contained(FilterSections, String);
+  // SHT_NULL section has no name.
+  if (!SecName.empty())
----------------
MaskRay wrote:
> jhenderson wrote:
> > Nit: The SHT_NULL...
> > 
> > But really, does this actually matter? I think it's harmless having it in the list right?
> > 
> > Happy for it to go in, if there's a good reason, or with this case removed.
> I think you meant the section with index 0 does not have a name.
Thank you. I should have been more clear here. The reason is that StringSet does not allow empty keys (assertion) and section 0 has no name.

Comment updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63779/new/

https://reviews.llvm.org/D63779