[PATCH] D63905: Fix ASAN error caused by commit r364512

Fri Jun 28 08:08:56 PDT 2019

dblaikie added a comment.

In D63905#1562040 <https://reviews.llvm.org/D63905#1562040>, @rovka wrote:

> In D63905#1561649 <https://reviews.llvm.org/D63905#1561649>, @dblaikie wrote:
>
> > Looks good to me, please commit
> >
> > (@rovka - this is at least a short-term fix, I'm approving this to unbreak LLVM's mainline - feel free to refix with other ideas if you have any (also happy to discuss this further with you here, IRC, or elsewhere on the mailing lists)
>
>
> Thanks for looking into it and sorry about the breakage. I think one InVReg is sufficient, there's no need for a whole SmallVector there. What do you think about something like this <https://reviews.llvm.org/differential/diff/207020/>?

Looks good to me - if possible, it'd be nice to have an assert that when assigning to the SwiftInVReg variable, it hasn't been assigned to before (just to demonstrate that invariant - that only one arg would ever be the error arg), but no worries if that's not practical (if there's no clear null state for a Register, etc)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63905/new/

https://reviews.llvm.org/D63905