[PATCH] D63816: [ARM] WLS/LE Code Generation

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMLowOverheadLoops.cpp:144
+        Pred = MBB;
+        Start = SearchForStart(MBB);
+      }
----------------
As soon as we found one, can we stop? Or, can we continue looking as a sanity check to see if we find more and bail with a diagnostic?


================
Comment at: lib/Target/ARM/ARMLowOverheadLoops.cpp:183
   if (Start || Dec || End) {
     if (!Start || !Dec || !End)
       report_fatal_error("Failed to find all loop components");
----------------
Who reviewed this? ;-) 
These 2 if statements here, can it just be this:
  
   if (!(Start && Dec && End))


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63816/new/

https://reviews.llvm.org/D63816