[PATCH] D63466: [Remarks] Add an LLVM-bitstream-based remark serializer

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg updated this revision to Diff 206982.
thegameg marked 7 inline comments as done.
thegameg added a comment.

- Address Jessica's comments.
- Rename `BLOCK_*` to `*_BLOCK_ID`.
- Teach `llvm-bcanalyzer` to recognize the magic number.
- Add a unit test to check for the values that shouldn't change without a version change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63466/new/

https://reviews.llvm.org/D63466

Files:
  llvm/include/llvm/IR/RemarkStreamer.h
  llvm/include/llvm/Remarks/BitstreamRemarkContainer.h
  llvm/include/llvm/Remarks/BitstreamRemarkSerializer.h
  llvm/include/llvm/Remarks/Remark.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/IR/RemarkStreamer.cpp
  llvm/lib/Remarks/BitstreamRemarkSerializer.cpp
  llvm/lib/Remarks/CMakeLists.txt
  llvm/lib/Remarks/RemarkStringTable.cpp
  llvm/test/Bitcode/stream-types.c
  llvm/test/Bitcode/stream-types.c.opt.bitstream
  llvm/test/CodeGen/X86/remarks-bitstream.ll
  llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
  llvm/unittests/Remarks/BitstreamRemarksFormatTest.cpp
  llvm/unittests/Remarks/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63466.206982.patch
Type: text/x-patch
Size: 34306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190628/15faee62/attachment-0001.bin>