[PATCH] D63841: [GWP-ASan] Add generic unwinders and structure backtrace output.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added a comment.

We will need something different for out-of-process unwinding, which is AFAIK a requirement both in android and chrome.



================
Comment at: compiler-rt/lib/gwp_asan/CMakeLists.txt:140
+      PARENT_TARGET gwp_asan)
+  endforeach()
 endif()
----------------
That's a lot of libraries. We need at most two - one standalone implementation for testing, and one "plugin" for the actual users.


================
Comment at: compiler-rt/lib/gwp_asan/guarded_pool_allocator.h:44
     // TODO(hctim): Implement stack frame compression, a-la Chromium.
     // Currently the maximum stack frames is one, as we don't collect traces.
+    static constexpr size_t kMaximumStackFrames = 64;
----------------
update the comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63841/new/

https://reviews.llvm.org/D63841