[PATCH] D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 12:48:17 PDT 2019


clayborg added a comment.

In D63828#1561085 <https://reviews.llvm.org/D63828#1561085>, @aprantl wrote:

> JF is currently working on making BitStream error-safe over in https://reviews.llvm.org/D63518. Perhaps there are some patterns that are worth copying.


Any pattern in particular? I would rather not have to try and take an error after every write. The ASMPrinter returns void. Do we even need a return value? We could store any errors internally in a contained lldb::Error that must be checked before the object is destructed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63828/new/

https://reviews.llvm.org/D63828





More information about the llvm-commits mailing list