[PATCH] D63779: [llvm-objdump] Warn if no user specified sections (-j) are found.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 01:17:01 PDT 2019


grimar added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:443
+      return;
+    MissingSections.insert(S);
+  }
----------------
grimar wrote:
> Instead, can you report a warning right here?
> 
> ```
> for (StringRef S : FilterSections) {
>   if (FoundSectionSet.count(S))
>     return;
>   warn("section '" + S + "' mentioned in a -j/--section option, but not "
>     "found in any input file");
> }
> ```
Ah, nevermind. I see why you can't now. Please ignore this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63779/new/

https://reviews.llvm.org/D63779





More information about the llvm-commits mailing list