[PATCH] D63525: LangRef: Attempt to formulate some rules for addrspacecast

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: docs/LangRef.rst:2713
+space. In general pointers with the bit-value 0 are assumed to be
+dereferencable in non-0 address spaces.
+
----------------
I'd change the last sentence, maybe as shown below, but the meaning is fine.

"In general, "null-pointers" have to be assumed dereferenceable in non-zero address spaces."


dereferencable -> dereferenceable


================
Comment at: docs/LangRef.rst:2720
+address spaces may have different trapping behavior when dereferencing
+an invalid pointer.
 
----------------
> For a non-volatile access, if an object can be proven accessible through a pointer with a different address space, the access may be modified to use that address space. 

I'm not happy with this wording,... but I can't quite put my finger on it.


================
Comment at: docs/LangRef.rst:9706
+side effects, or capture the value of the pointer.
+
+If the source is :ref:`poison <poisonvalues>`, the result is
----------------
> same memory location.

Is it necessarily the same memory location or the same "logical" memory location? This is an honest question.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63525/new/

https://reviews.llvm.org/D63525