[PATCH] D63849: AMDGPU: Make s34 the FP register

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 16:09:25 PDT 2019


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFrameLowering.cpp:63
+      if (!MRI.isPhysRegUsed(Reg) && LiveRegs.available(MRI, Reg))
+        return Reg;
+    }
----------------
As far as I understand that can break limits set on the number of registers by an user.


================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:74
+
+    // TODO: Pick a high register, and shift down, similar to a kernel.wwwwwwwwwwww
+    FrameOffsetReg = AMDGPU::SGPR34;
----------------
wwwwwwwww


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63849/new/

https://reviews.llvm.org/D63849





More information about the llvm-commits mailing list