[PATCH] D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added a comment.

In D63782#1558430 <https://reviews.llvm.org/D63782#1558430>, @efriedma wrote:

> What happens if the input float is out of range?  fptosi/fptoui instructions produce poison; not sure if you want that here.


Is this a general comment or referring to a change in Kevin's patch?

Unless I'm misunderstanding, we should be leaving the constrained converts alone until a hardware instruction is produced. In the ConvertToInteger cases, the hw instructions should flag Invalid and then the rounding mode will determine the result.

If you're asking what would happen if we found a poison value as the fptoXi's operand, that's a tougher question...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63782/new/

https://reviews.llvm.org/D63782