[PATCH] D63215: Fixing @llvm.memcpy not honoring volatile

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 11:48:49 PDT 2019


efriedma accepted this revision.
efriedma added a comment.

Maybe mention in the commit message that this is explicitly not addressing target-specific code, or calls to memcpy?

I don't agree with the "undef" FIXME (a load/store from undef is UB, whether or not it's volatile), but the check for undef is very unlikely to matter in practice anyway.

Otherwise LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63215/new/

https://reviews.llvm.org/D63215





More information about the llvm-commits mailing list