[PATCH] D63706: [InlineCost] Fix bug 42084: remember negative result when computing full inline cost

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

An example of inline-cost usage for the purpose of "inline body investigation" on inlining validity is in SampleProfileLoader::inlineCallInstruction.
Comments from it:

  // Checks if there is anything in the reachable portion of the callee at
  // this callsite that makes this inlining potentially illegal.

It is interesting that initial version of D37779 <https://reviews.llvm.org/D37779> that introduced this usage was initially setting "kinda infinite" Threshold in order to reach the same effect.

It does seem that we need a more disciplined interface for the "investigation" mode, but in absence of that ComputeFullInlineCost mode needs to adhere to the initial idea of traversing *all* the reachable instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63706/new/

https://reviews.llvm.org/D63706