[PATCH] D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 23:55:16 PDT 2019


Meinersbur added a comment.

[suggestion] `RecordedAssumptions` itself is only used during SCoP constructions (since it's empty once the SCoP is full constructed).  It could be removed entirely into ScopBuilder, maybe in a future patch?



================
Comment at: polly/lib/Analysis/ScopBuilder.cpp:391
+
+    //    Assumption &AS = scop->popRecordedAssumption();
+    if (!AS.BB) {
----------------
Please remove commented-out code entirely.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63572/new/

https://reviews.llvm.org/D63572





More information about the llvm-commits mailing list