[PATCH] D63797: Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group.

[Dan Liew via Phabricator via llvm-commits]

delcypher created this revision.
delcypher added reviewers: yln, kubamracek, vsk, samsonov.
Herald added projects: Sanitizers, LLVM.
Herald added a subscriber: Sanitizers.

Previously we were running these tests without the "shadow-memory"
lit parallelism group even though we run the ASan and TSan tests in
this group to avoid problems with many processes using shadow memory
in parallel.

On my local machine the UBSan+TSan tests would previously timeout
if I set a 30 second per test limit. With this change I no longer
see individual test timeouts.

This change was made in response to the greendragon build bot reporting
individual test timeouts for these tests. Given that the UBSan+ASan and
UBSan+TSan tests did not have a parallelism group previously it's likely
that some other change has caused the performance degradation. However
I haven't been able to track down the cause so until we do, this change
seems reasonable and is in line with what we already do with ASan and
TSan tests.

rdar://problem/51754620


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63797

Files:
  compiler-rt/test/ubsan/lit.common.cfg


Index: compiler-rt/test/ubsan/lit.common.cfg
===================================================================
--- compiler-rt/test/ubsan/lit.common.cfg
+++ compiler-rt/test/ubsan/lit.common.cfg
@@ -74,3 +74,7 @@
 config.available_features.add('arch=' + config.target_arch)
 
 config.excludes = ['Inputs']
+
+if "ubsan-asan" in config.available_features or "ubsan-tsan" in config.available_features:
+  if not config.parallelism_group:
+    config.parallelism_group = 'shadow-memory'


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63797.206549.patch
Type: text/x-patch
Size: 486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190625/8f1840ed/attachment.bin>