[PATCH] D63775: [LLD][COFF] Case insensitive compares for /nodefaultlib

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 11:25:43 PDT 2019


rnk added a comment.

I guess /nodefaultlib just isn't that common compared to /defaultlib, so this hadn't been reported yet. Fix makes sense to me.



================
Comment at: COFF/Driver.cpp:303
+static std::string normalizeLibPath(StringRef path) {
+#if defined(_WIN32)
+  return path.lower();
----------------
I don't think we want this ifdef, I think we want LLD to do this when cross-linking from Linux to Windows. This is something we try to support for Chromium:
https://chromium.googlesource.com/chromium/src/+/master/docs/win_cross.md


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63775/new/

https://reviews.llvm.org/D63775





More information about the llvm-commits mailing list