[PATCH] D63109: lld-link: Reject more than one resource .obj file

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 04:09:22 PDT 2019


thakis added a comment.

In D63109#1556386 <https://reviews.llvm.org/D63109#1556386>, @mstorsjo wrote:

> Actually, it turns out that GNU windres does things differently - GNU ld can link two resource object files from GNU windres, and resources from both end up reachable. When faced with two resource files from llvm-cvtres, only resources from the first one ends up accessible. In the converse case, if lld is given a resource object file from GNU windres (even a single one), those resources aren't reachable at all.


I think all four combinations of {llvm-cvtres,cvtres.exe} x {llvm-link,link.exe} should have the same behavior. What does link.exe say to two windres outputs? What does GNU ld do with two cvtres.exe inputs?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63109/new/

https://reviews.llvm.org/D63109





More information about the llvm-commits mailing list