[PATCH] D63306: Add a remarks-based code size diffing tool

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

In D63306#1543925 <https://reviews.llvm.org/D63306#1543925>, @paquette wrote:

> In D63306#1543020 <https://reviews.llvm.org/D63306#1543020>, @echristo wrote:
>
> > Haven't done much of a review, one drive by, but in general I like the idea. Would it make sense to have a general "remarks in object files" tool rather than just a size one? (It can, of course, only do size at the beginning.)
> >
> > Thoughts?
>
>
> Hmmm. That sounds similar to a more detailed version of opt-diff? (With added support for object files)
>
> (I suppose that basically every pass can impact code size though, so I could see basically every remark being correlated with size.)
>
> Do you have anything in particular in mind for what a more general tool would look like?


Nothing in particular, I figure growing an existing related tool makes as much sense as creating a new one? Up to you ultimately though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63306/new/

https://reviews.llvm.org/D63306