[PATCH] D63672: Added Delta IR Reduction Tool

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 14:29:31 PDT 2019


chandlerc added a comment.

Personally, I'd suggest the name `llvm-reduce` for the tool.

As mentioned already, good to follow the LLVM coding standards:
http://llvm.org/docs/CodingStandards.html

You can get a long way by using `clang-format` which should automatically detect the correct style from your checkout.

You may also want to take a look through the programmer's manual if you haven't seen it, although I think you're already aware of much of this:
http://llvm.org/docs/ProgrammersManual.html

It would generally help me to have doxygen comments for the main types and public interfaces explaining what they're trying to do and how they should be used. (Can see some example syntax for this in the coding standards and some examples in other parts of LLVM.)



================
Comment at: llvm/tools/bp2/bugpoint.md:1-3
+# Bugpoint Redesign
+Author: Diego Treviño (diegotf at google.com)
+
----------------
There is an `llvm/docs` tree that the design document should go into. You can use markdown here, see the `SpeculativeLoadHardening.md` doc and some others.


================
Comment at: llvm/tools/bp2/bugpoint.md:10
+## Introduction
+As use of bugpoint has grown several areas of improvement have been identified through years of use: confusing to use, slow, it doesn’t always produce high quality test cases, etc. This document proposes a new approach with a narrower focus: minimization of IR test cases.
+
----------------
Even in documentation, please use 80-columns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63672/new/

https://reviews.llvm.org/D63672





More information about the llvm-commits mailing list