[PATCH] D63711: [ARM] MVE VPT Blocks

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp:403
+      NextPred = getVPTInstrPredicate(*NextInst, PredReg);
+      LastMI = NextInst;
+      VPTInstCnt++;
----------------
Do we need to keep track of LastMI? Looks like it's only used to get an iterator once out of the loop, but it is derived from MBIter anyway...


================
Comment at: llvm/test/CodeGen/ARM/mve-vpt-block5.mir:66
+
+    ; CHECK:       BUNDLE {{.*}} {
+    ; CHECK-NEXT:    MVE_VPST 8, implicit-def $p0
----------------
So why do we have two bundles here? I'm missing something...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63711/new/

https://reviews.llvm.org/D63711