[PATCH] D63699: [llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI

[Seiya Nuta via Phabricator via llvm-commits]

seiya created this revision.
Herald added subscribers: llvm-commits, jakehehrlich.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.

Use MachOObjectFile::isRelocationScattered instead of reinterpret_cast.

Fixes https://bugs.llvm.org/show_bug.cgi?id=42360


https://reviews.llvm.org/D63699

Files:
  llvm/tools/llvm-objcopy/MachO/MachOReader.cpp


Index: llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
===================================================================
--- llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
+++ llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
@@ -93,7 +93,7 @@
           StringRef(reinterpret_cast<const char *>(E->data()), E->size());
     else
       reportError(MachOObj.getFileName(), E.takeError());
-
+      
     S.Relocations.reserve(S.NReloc);
     for (auto RI = MachOObj.section_rel_begin(SecRef->getRawDataRefImpl()),
               RE = MachOObj.section_rel_end(SecRef->getRawDataRefImpl());
@@ -101,9 +101,7 @@
       RelocationInfo R;
       R.Symbol = nullptr; // We'll fill this field later.
       R.Info = MachOObj.getRelocation(RI->getRawDataRefImpl());
-      R.Scattered =
-          reinterpret_cast<MachO::scattered_relocation_info *>(&R.Info)
-              ->r_scattered;
+      R.Scattered = MachOObj.isRelocationScattered(R.Info);
       S.Relocations.push_back(R);
     }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63699.206154.patch
Type: text/x-patch
Size: 982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190624/a25d9287/attachment.bin>