[PATCH] D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.

Hsiangkai Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 22 18:43:58 PDT 2019


HsiangKai marked an inline comment as done.
HsiangKai added a comment.

Use llvm-dwarfdump to ensure DWARF parsing is correct under relaxation.



================
Comment at: test/DebugInfo/RISCV/relax-debug-frame.ll:8
+; RELAX: R_RISCV_SET6
+; RELAX: R_RISCV_SUB6
+source_filename = "frame.c"
----------------
probinson wrote:
> Do you have a way to prove these relocations are in the right section? Right now the test verifies that they come after the start of the .rela.*_frame section, but it does not verify they come before the end of the section.
I check the end of section '}' before every pair of checking strings. It could ensure these strings within one section.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58335/new/

https://reviews.llvm.org/D58335





More information about the llvm-commits mailing list