[PATCH] D63619: [AMDGPU] hazard recognizer for fp atomic to s_denorm_mode

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 21 06:31:42 PDT 2019


arsenm added a comment.

LGTM assuming the DS atomics really aren't impacted



================
Comment at: lib/Target/AMDGPU/BUFInstructions.td:696
+                                        bit isFP = getIsFP<vdataType>.ret> {
+  let FPAtomic = isFP in
   def _OFFSET : MUBUF_AtomicNoRet_Pseudo <opName, BUFAddrKind.Offset, vdataClass>,
----------------
I didn't know you could omit the braces here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63619/new/

https://reviews.llvm.org/D63619





More information about the llvm-commits mailing list