[PATCH] D63657: [benchmark] Change GetGitVersion to only check "dirty" when a tag is found

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 22 11:58:09 PDT 2019


andrewng added a comment.

In D63657#1553962 <https://reviews.llvm.org/D63657#1553962>, @lebedev.ri wrote:

> (that being said this entire script is kinda bogus, in this sense of integration into other build, the version tag makes no sense since it will be a llvm-one)


Yes, it doesn't really apply in this usage scenario. Perhaps the versioning should be changed or disabled in some way?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63657/new/

https://reviews.llvm.org/D63657





More information about the llvm-commits mailing list