[PATCH] D63505: [InstCombine] Fold icmp eq/ne (and %x, C), 0 iff (-C) is power of two -> %x u</u>= (-C) earlier.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 22 02:14:18 PDT 2019


lebedev.ri added a comment.

Looks good. I'll accept at the same time with D63675 <https://reviews.llvm.org/D63675>.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:1656
+
+    // Restrict this fold to single-use 'and' (PR10267).
+    // ((%x & C) == 0) --> %x u< (-C)  iff (-C) is power of two.
----------------
s/to/only for/


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63505/new/

https://reviews.llvm.org/D63505





More information about the llvm-commits mailing list