[PATCH] D63341: [llvm-lipo] Implement -thin

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.

LGTM



================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:95
 
+static void validateArchitectureName(StringRef ArchitectureName);
+
----------------
Nit: you can just move the function instead of adding a prototype.


================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:106
+    reportError("missing argument to " +
+                std::string(InputArgs.getArgString(MissingArgumentIndex)) +
+                " option");
----------------
Nit: StringRef should be enough to trigger the Twine construction and is more efficient here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63341/new/

https://reviews.llvm.org/D63341