[PATCH] D62997: [LV] Share the LV illegality reporting with LoopVectorize. NFC.

Fri Jun 21 12:26:52 PDT 2019

hsaito added a comment.

In D62997#1553998 <https://reviews.llvm.org/D62997#1553998>, @rengolin wrote:

> In D62997#1551946 <https://reviews.llvm.org/D62997#1551946>, @psamolysov wrote:
>
> > The diff has been updated: private methods were removed, the function 'reportVectorizationFailure' was moved to `LoopVectorize.cpp` and declared in `LoopVectorize.h` (namespace `llvm`). I've removed the `passName` parameter and pass `LV_NAME` as pass name to `ORE` but this change breaks 3 regression tests:
>
>
> I'm assuming that the pass name isn't just LV_NAME, but whichever pass is using that function, which now that it's higher level, can be anything.
>
> > @rengolin @hsaito I need you suggestions how to deal with the `Hints.vectorizeAnalysisPassName()`  method, it is very long to always call it whenever the `reportVectorizationFailure` is invoked.
>
> I don't have a better idea on the top of my head, but this sounds like a change that can be done later as a quick refactory once someone comes up with a clever replacement.
>
> I'd be ok having that for now... @hsaito may have a better idea, though.
>
> --renato

I don't have a better idea, but I think the 3 failed tests are worth looking into, in trying to understand why we would want to emit the remark always. Which test failed?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62997/new/

https://reviews.llvm.org/D62997