[PATCH] D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>

[David Greene via Phabricator via llvm-commits]

greened added inline comments.


================
Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:375
   default: break;
+  case MVT::iPTR:
+    UpdateArgCodes(R->getValueAsDef("ElTy"), ArgCodes, NumInserted, Mapping);
----------------
Since I don't know this code I can't say whether it's correct, but it seems odd to me that this `iPTR` case is needed to handle ptr-to-any when `iPTRAny` is a case right below.  Does `iPTRAny` not mean "ptr-to-any?"  At the very least a comment would be helpful explaining what is going on here and why we need a separate `iPTR` case to handle ptr-to-any.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63507/new/

https://reviews.llvm.org/D63507