[PATCH] D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol

Fri Jun 21 02:28:20 PDT 2019

peter.smith added a comment.

In D63280#1553221 <https://reviews.llvm.org/D63280#1553221>, @jhenderson wrote:

> @MaskRay, @peter.smith, is it just the PLT that is specially handled? Perhaps we could just special-case that in llvm-objdump? I think there's clear precedence for this for other versions of objdump, so I'm okay with that difference in behaviour.
>
> It seems to me like other cases of this syntax appearing are going to be very rare overall.

>From a cursory scan https://github.com/bminor/binutils-gdb/blob/master/binutils/objdump.c#L749 it looks like the .plt and .got are treated specially by objdump and can remain candidates for disassembly. I agree that it is likely to be linker generated content such as .plt sections that are likely to not have a code symbol at address 0.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63280/new/

https://reviews.llvm.org/D63280