[PATCH] D62718: [llvm-objcopy] Change handling of output file permissions

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with the suggested comment changes, but please wait for the other patch, and @MaskRay's agreement.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/mirror-permissions-unix.test:4
+
+## Unix version of this test must use umask(1)
+## or tests might fail.
----------------
You could probably combine this comment paragraph with the initial one.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/mirror-permissions-win.test:4
+
+# REQUIRES: system-windows
+
----------------
This should have a comment explaining why this test is Windows-specific.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62718/new/

https://reviews.llvm.org/D62718