[PATCH] D63521: Teach the symbolizer lib symbolize objects directly.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I am probably not the right person to accept this, so minor suggestion is below.



================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:92
+  }
+
+  return symbolizeCodeCommon(Info, ModuleOffset);
----------------
I'd simplify.

```
  const auto &I = Modules.find(ModuleName);
  if (I != Modules.end())
    return symbolizeCodeCommon(I->second.get(), ModuleOffset);

  Expected<SymbolizableModule *> InfoOrErr =
                      createModuleInfo(&Obj, std::move(Context), ModuleName);
  if (!InfoOrErr)
    return InfoOrErr.takeError();
  return symbolizeCodeCommon(InfoOrErr.get(), ModuleOffset);
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63521/new/

https://reviews.llvm.org/D63521