[PATCH] D63631: [llvm-objdump] Move --start-address >= --stop-address check out of the -d code.

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 20 20:50:22 PDT 2019


ychen marked an inline comment as done.
ychen added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/start-stop-address.test:72
 // RUN: not llvm-objdump -d %t.out --start-address=0x40 --stop-address=0x40 2>&1 | FileCheck %s --check-prefix ERRMSG
+// RUN: not llvm-objdump    %t.out --start-address=0x40 --stop-address=0x3f 2>&1 | FileCheck %s --check-prefix ERRMSG
+// RUN: not llvm-objdump -r %t.out --start-address=0x40 --stop-address=0x3f 2>&1 | FileCheck %s --check-prefix ERRMSG
----------------
MaskRay wrote:
> If this line (no command specified) gives diagnostics, the `-d` `-r` `-s` RUN lines may be unnecessary.
Missed that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63631/new/

https://reviews.llvm.org/D63631





More information about the llvm-commits mailing list