[PATCH] D41111: [profile] Solaris ld supports __start___llvm_prof_data etc. labels

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 20 14:25:45 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL363984: [profile] Solaris ld supports __start___llvm_prof_data etc. labels (authored by ro, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D41111?vs=205802&id=205901#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41111/new/

https://reviews.llvm.org/D41111

Files:
  llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp
  llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll


Index: llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll
===================================================================
--- llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll
+++ llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll
@@ -42,19 +42,16 @@
 ; MACHO-NOT: define internal void @__llvm_profile_register_functions
 ; LINUX-NOT: define internal void @__llvm_profile_register_functions
 ; FREEBSD-NOT: define internal void @__llvm_profile_register_functions
+; SOLARIS-NOT: define internal void @__llvm_profile_register_functions
 ; PS4-NOT: define internal void @__llvm_profile_register_functions
 ; WINDOWS-NOT: define internal void @__llvm_profile_register_functions
 
 ;; PR38340: When dynamic registration is used, we had a bug where we'd register
 ;; something that's not a __profd_* variable.
 
-; SOLARIS: define internal void @__llvm_profile_register_functions
-; SOLARIS-NOT: __llvm_profile_runtime_user
-; SOLARIS: ret void
-
 ; MACHO-NOT: define internal void @__llvm_profile_init
 ; LINUX-NOT: define internal void @__llvm_profile_init
 ; FREEBSD-NOT: define internal void @__llvm_profile_init
+; SOLARIS-NOT: define internal void @__llvm_profile_init
 ; PS4-NOT: define internal void @__llvm_profile_init
 ; WINDOWS-NOT: define internal void @__llvm_profile_init
-; SOLARIS: define internal void @__llvm_profile_init
Index: llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp
+++ llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp
@@ -713,7 +713,8 @@
     return false;
   // Use linker script magic to get data/cnts/name start/end.
   if (TT.isOSLinux() || TT.isOSFreeBSD() || TT.isOSNetBSD() ||
-      TT.isOSFuchsia() || TT.isPS4CPU() || TT.isOSWindows())
+      TT.isOSSolaris() || TT.isOSFuchsia() || TT.isPS4CPU() ||
+      TT.isOSWindows())
     return false;
 
   return true;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41111.205901.patch
Type: text/x-patch
Size: 1985 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190620/03fd92ca/attachment.bin>


More information about the llvm-commits mailing list