[PATCH] D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>

[David Greene via Phabricator via llvm-commits]

greened added inline comments.


================
Comment at: llvm/test/TableGen/intrinsic-pointer-to-any.td:1
+// RUN: llvm-tblgen -gen-intrinsic-impl %s | FileCheck %s
+
----------------
Could we have a comment here explaining what this is testing and what went wrong before this patch?


================
Comment at: llvm/test/TableGen/intrinsic-pointer-to-any.td:22
+class Intrinsic<list<LLVMType> ret_types,
+                list<LLVMType> param_types = [],
+                list<IntrinsicProperty> intr_properties = [],
----------------
Do we need this and the below parameters for the test?  AFAICT they are never passed.


================
Comment at: llvm/test/TableGen/intrinsic-pointer-to-any.td:25
+                string name = ""> {
+  string LLVMName = name;
+  string TargetPrefix = "";   // Set to a prefix for target-specific intrinsics.
----------------
Are the members here expected to exist by `IntrinsicEmitter`?  If so, defaults could be set directly rather than using default arguments that are never passed.  If not, we could just delete them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63507/new/

https://reviews.llvm.org/D63507