[PATCH] D63614: [System Model] [TTI] Update cache and prefetch TTI interfaces

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 20 10:17:12 PDT 2019


greened created this revision.
greened added reviewers: kparzysz, MatzeB, arsenm, jdoerfert, simoll, Meinersbur, hfinkel, andreadb, rengolin, steleman, ajasty-cavium, joelkevinjones, anemet, grosser.
greened added a project: LLVM.
Herald added subscribers: llvm-commits, jsji, kbarton, hiraditya, kristof.beyls, javed.absar, wdng, nemanjai.

Rework the TTI cache and software prefetching APIs to prepare for the
introduction of a general system model.  Changes include:

- Marking existing interfaces const and/or override as appropriate
- Adding comments
- Adding BasicTTIImpl interfaces that delegate to a subtarget implementation
- Adding a default "no information" subtarget implementation

Only a handful of targets use these interfaces currently: AArch64,
Hexagon, PPC and SystemZ.  AArch64 already has a custom subtarget
implementation, so its custom TTI implementation is migrated to use
the new facilities in BasicTTIImpl to invoke its custom subtarget
implementation.  The custom TTI implementations continue to exist for
the other targets with this change.  They are not moved over to
subtarget-based implementations.

The end goal is to have the default subtarget implementation defer to
the system model defined by the target.  With this change, the default
subtarget implementation essentially returns "no information" for
these interfaces.  None of the existing users of TTI will hit that
implementation because they define their own custom TTI
implementations and won't use the BasicTTIImpl implementations.

Once system models are in place for the targets that use these
interfaces, their custom TTI implementations can be removed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63614

Files:
  llvm/include/llvm/Analysis/TargetTransformInfo.h
  llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/include/llvm/CodeGen/BasicTTIImpl.h
  llvm/include/llvm/MC/MCSubtargetInfo.h
  llvm/lib/MC/MCSubtargetInfo.cpp
  llvm/lib/Target/AArch64/AArch64Subtarget.h
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h
  llvm/lib/Target/Hexagon/HexagonTargetTransformInfo.h
  llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
  llvm/lib/Target/PowerPC/PPCTargetTransformInfo.h
  llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63614.205853.patch
Type: text/x-patch
Size: 17060 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190620/de5e809a/attachment.bin>


More information about the llvm-commits mailing list