[PATCH] D63327: [docs][llvm-nm] Improve symbol code documentation

[James Henderson via Phabricator via llvm-commits]

jhenderson marked 2 inline comments as done.
jhenderson added inline comments.


================
Comment at: docs/CommandGuide/llvm-nm.rst:81
+
+ Named object is referenced but undefined in this file.
+
----------------
MaskRay wrote:
> It doesn't have to be "referenced".
> 
> ```
> as /dev/null -o a.o
> ld.bfd a.o -u foo -o a  # or gold; but ld.lld doesn't have this behavior
> nm a => U foo
> ```
> 
> though `foo` is not referenced...
You're right. This one is just moved from earlier, but we can update it now to be better.


================
Comment at: docs/CommandGuide/llvm-nm.rst:89
+
+ ELF: Weak object definition. Multiple definitions link together into zero or one definitions.
+
----------------
MaskRay wrote:
> > Multiple definitions link together into zero or one definitions.
> 
> This sentence makes me puzzled. You may delete it if no better description can be found.
> 
How about "This definition will only be used if no regular definitions exist in a link. If multiple weak definitions and no regular definitons exist, one of the weak definitions will be used."?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63327/new/

https://reviews.llvm.org/D63327