[PATCH] D63430: [ARM] Add support for the MVE long shift instructions

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:5553
+      if (!Con)
+        // If the shift amount is in a register then negate it and perform an
+        // lsll
----------------
samparker wrote:
> This isn't immediately obvious to me why this is correct, so could you please expand in the comment?
Maybe be explicit that there isn't a t2LSRLr instruction, which is why the negative t2LSLLr is needed.


================
Comment at: llvm/test/CodeGen/ARM/shift_parts.ll:168
+
+; Function Attrs: norecurse nounwind
+define arm_aapcs_vfpcc void @fn1(%struct.bar* nocapture %a) {
----------------
You can remove this comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63430/new/

https://reviews.llvm.org/D63430