[PATCH] D60389: FileCheck [9/12]: Add support for matching formats

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:74
+  auto FoobarExpr = FileCheckNumExpr(Binop, FmtUnsigned);
   FileCheckNumericVariable FoobarVar =
+      FileCheckNumericVariable(2, "FOOBAR", &FoobarExpr);
----------------
MaskRay wrote:
> `FileCheckNumericVariable FoobarVar(...)` or `FileCheckNumericVariable FoobarVar{...}`
Is that the expected usage in LLVM? I've already added quite a lot of occurences in existing code, that would need to be taken care in a separate patch IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60389/new/

https://reviews.llvm.org/D60389