[PATCH] D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output.

Thu Jun 20 02:16:57 PDT 2019

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with the suggested change, but please wait for the other reviewers to confirm too.

================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-dynamic-symbols.test:24
 # STATIC-NEXT: 0000000000001002 only_static:
-# CHECK-NEXT:      1002:
+# STATIC-NEXT:     1002:
+# DYN-NEXT:    0000000000001003 func:
----------------
ychen wrote:
> jhenderson wrote:
> > This looks wrong, and I'm surprised this test isn't failing now. As things stand 0x1002 isn't being checked for at all in dynamic output, but there's no reason it shouldn't be there.
> both_dyn is STT_OBJECT, dumped as data in one line until the next symbol regardless of its size.
Ah, okay. Probably worth making both_dyn the STT_NOTYPE symbol then and making what is currently notype the STT_OBJECT one. That'll be less confusing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62964/new/

https://reviews.llvm.org/D62964